Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to invite team members in bulk #2424

Merged
merged 12 commits into from
Apr 18, 2024

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Apr 10, 2024

What does this PR do?

Fixes #2413

Settings._.Formbricks.and.4.more.pages.-.Personal.-.Microsoft_.Edge.2024-04-10.20-53-13.mp4

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 10, 2024

@anikdhabal is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@github-actions github-actions bot added the enhancement New feature or request label Apr 10, 2024
@mattinannt
Copy link
Member

@anikdhabal thanks a lot for the PR :-) 💪 We will review it as soon as possible :-)

Copy link
Contributor

@Dhruwang Dhruwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @anikdhabal , thank you for this super cool feature, works pretty well 🤩🚀🙌🏻. Here are some minor issues that I noticed !

  1. Padding is a bit odd, we can reduce it a bit
Screenshot 2024-04-11 at 1 18 07 PM
  1. Invite modal does not closes, when clicking outside

  2. Need to click twice on Template button in order to download it

  3. Here button label feels confusing can we change the label of the button here to Download Template (with a download lucide-icon) ?

Screenshot 2024-04-11 at 2 25 45 PM
  1. Role management is not available in free plan and we do now allow users to invite team members with role other than Admin on a free plan and your code handles that case well 😊🙌🏻
    Screenshot 2024-04-11 at 2 21 43 PM
    But if this is the case, along with converting the roles to admin we also want to show a warning about it. Maybe something like this

Please note that on the Free Plan, all team members are automatically assigned the "Admin" role regardless of the role specified in the CSV file.

@anikdhabal
Copy link
Contributor Author

Thanks @Dhruwang for the review. Let me fix them quickly.

@jobenjada
Copy link
Member

Pls change the button "Template" to variant=minimal and text Download CSV template

Copy link
Contributor

@Dhruwang Dhruwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good 😊🚀

@jobenjada
Copy link
Member

UI / UX looks good, over to @mattinannt

@mattinannt mattinannt added this pull request to the merge queue Apr 18, 2024
Merged via the queue into formbricks:main with commit 1ddd1cf Apr 18, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Ability to send team invitations in bulk
5 participants