-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ability to invite team members in bulk #2424
Conversation
@anikdhabal is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 🙏 |
@anikdhabal thanks a lot for the PR :-) 💪 We will review it as soon as possible :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @anikdhabal , thank you for this super cool feature, works pretty well 🤩🚀🙌🏻. Here are some minor issues that I noticed !
- Padding is a bit odd, we can reduce it a bit
![Screenshot 2024-04-11 at 1 18 07 PM](https://private-user-images.githubusercontent.com/67850763/321564554-8bfd323f-6215-44fd-850a-6cfb7da059fc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTk1MTksIm5iZiI6MTcyMTUxOTIxOSwicGF0aCI6Ii82Nzg1MDc2My8zMjE1NjQ1NTQtOGJmZDMyM2YtNjIxNS00NGZkLTg1MGEtNmNmYjdkYTA1OWZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIzNDY1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVlYjgzYzgxY2IxNzE2NGIzZjcwMDhkNjRmMzMzY2NmNmMyY2FjN2JkMTEzYWQyMzExMjFjYmVjNTEyMGM4M2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Q8ODxqN87_5WcVkca5cSGBZNqOWwWvH-jYMjWYzRYIY)
-
Invite modal does not closes, when clicking outside
-
Need to click twice on Template button in order to download it
-
Here button label feels confusing can we change the label of the button here to Download Template (with a download lucide-icon) ?
![Screenshot 2024-04-11 at 2 25 45 PM](https://private-user-images.githubusercontent.com/67850763/321565025-73d920ba-a2aa-46fa-80ec-c7884574ad54.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MTk1MTksIm5iZiI6MTcyMTUxOTIxOSwicGF0aCI6Ii82Nzg1MDc2My8zMjE1NjUwMjUtNzNkOTIwYmEtYTJhYS00NmZhLTgwZWMtYzc4ODQ1NzRhZDU0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIzNDY1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRmNjBjOTc2NDg1YWIxMWQ3YWJlOTAzMzJmNWYxMDNmOWIxZWMxMDJkNDVkNTUxNGQ4ZGU2NWMwMjI5NTQ3MmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.T8owCHtGLwTIJ7pKcmcR6-Vx8F1bx__0Sg0vp81AJpI)
- Role management is not available in free plan and we do now allow users to invite team members with role other than Admin on a free plan and your code handles that case well 😊🙌🏻
But if this is the case, along with converting the roles to admin we also want to show a warning about it. Maybe something like this
Please note that on the Free Plan, all team members are automatically assigned the "Admin" role regardless of the role specified in the CSV file.
apps/web/app/(app)/environments/[environmentId]/settings/members/components/BulkImportTab.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/(app)/environments/[environmentId]/settings/members/components/BulkImportTab.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/(app)/environments/[environmentId]/settings/members/components/BulkImportTab.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/(app)/environments/[environmentId]/settings/members/components/AddMemberModal.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/(app)/environments/[environmentId]/settings/members/components/BulkImportTab.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/(app)/environments/[environmentId]/settings/members/components/BulkImportTab.tsx
Outdated
Show resolved
Hide resolved
...b/app/(app)/environments/[environmentId]/settings/members/components/IndividualInviteTab.tsx
Outdated
Show resolved
Hide resolved
...pp)/environments/[environmentId]/settings/members/components/EditMemberships/TeamActions.tsx
Outdated
Show resolved
Hide resolved
Thanks @Dhruwang for the review. Let me fix them quickly. |
Pls change the button "Template" to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good 😊🚀
UI / UX looks good, over to @mattinannt |
What does this PR do?
Fixes #2413
Settings._.Formbricks.and.4.more.pages.-.Personal.-.Microsoft_.Edge.2024-04-10.20-53-13.mp4
How should this be tested?
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated