Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenTextSummary no longer has "Show more" button #2427

Merged
merged 6 commits into from
Apr 12, 2024
Merged

fix: OpenTextSummary no longer has "Show more" button #2427

merged 6 commits into from
Apr 12, 2024

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

  • Increases the limit of open text responses: 10 -> 50
  • adds show more button

Fixes #2336

How should this be tested?

  • Check summary of openText, date, file upload, hidden field with more than 10 responses

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Apr 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 1:59pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 12, 2024 1:59pm

@github-actions github-actions bot added the bug Something isn't working label Apr 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 12, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@gupta-piyush19 gupta-piyush19 changed the title 2336 bug regression opentextsummary no longer has show more button fix: OpenTextSummary no longer has "Show more" button Apr 12, 2024
@jobenjada jobenjada self-requested a review April 12, 2024 11:13
mattinannt
mattinannt approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 code approved :-) ✅ @jobenjada will do a quick UI check before merging

@jobenjada jobenjada added this pull request to the merge queue Apr 12, 2024
jobenjada
jobenjada approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve my own UI tweaks nhnhnh

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2024
@mattinannt mattinannt added this pull request to the merge queue Apr 12, 2024
Merged via the queue into main with commit f07dffa Apr 12, 2024
12 checks passed
@mattinannt mattinannt deleted the 2336-bug-regression-opentextsummary-no-longer-has-show-more-button branch April 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

@jobenjada jobenjada jobenjada approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] regression: OpenTextSummary no longer has "Show more" button
3 participants
@gupta-piyush19 @mattinannt @jobenjada