Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Event listener doc #2432

Merged
merged 5 commits into from
Apr 22, 2024
Merged

docs: Event listener doc #2432

merged 5 commits into from
Apr 22, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Docs for formbricksSurveyCompleted message event

Screenshot 2024-04-12 at 3 35 13 PM Screenshot 2024-04-12 at 3 35 03 PM

How should this be tested?

Check link survey docs

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@Dhruwang Dhruwang requested a review from jobenjada April 12, 2024 10:17
Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 11:50am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 11:50am

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :) It's missing a few images and going forward it would be cool to have videos instead of lots of images (easy to record, handle and watch).

I added one but there is an issue with loading it in the Docs app.

Please make it work and consult with @ShubhamPalriwala if you have doubts, he set up the docs app :)

Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@jobenjada jobenjada added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 2ff17c2 Apr 22, 2024
12 checks passed
@jobenjada jobenjada deleted the event-listener-doc branch April 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants