Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix S3_BUCKET_NAME env var in docs #2448

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Fixes #2447

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Apr 14, 2024 8:47pm
formbricks-com ⬜️ Ignored (Inspect) Apr 14, 2024 8:47pm

@github-actions github-actions bot added the bug Something isn't working label Apr 14, 2024
Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thanks for the fix; looks good 😊💪

@mattinannt mattinannt added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 933ea87 Apr 15, 2024
14 checks passed
@mattinannt mattinannt deleted the shubham/docs-fix-aws-s3-env branch April 15, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Local storage always used even if S3 configuration is set
2 participants