Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve Debug messages #2451

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

jonas-hoebenreich
Copy link
Contributor

What does this PR do?

This PR adds the survey name to debug messages to make it easier to debug certain issues.
It also fixes a small typo in "Click-through rate" (it now uses the "official" Wikipedia spelling: https://en.wikipedia.org/wiki/Click-through_rate)
It also renames "responses" to "clicks" in the CTA tile.

Fixes # (issue)

How should this be tested?

  • check debug messages
  • check CTA tile

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 15, 2024

@jonas-hoebenreich is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Apr 15, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jonas-hoebenreich jonas-hoebenreich changed the title [chore] Improve Debug messages chore: Improve Debug messages Apr 15, 2024
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonas-hoebenreich looks great, thanks a lot for these improvements :-) 💪

@mattinannt mattinannt added this pull request to the merge queue Apr 15, 2024
Merged via the queue into formbricks:main with commit 529144f Apr 15, 2024
9 of 12 checks passed
@jonas-hoebenreich jonas-hoebenreich deleted the improve-pixel branch April 15, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants