Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added logic to show tags for viewer role #2454

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: added logic to show tags for viewer role #2454

merged 2 commits into from
Apr 18, 2024

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

Added logic to show tags for viewer role

Fixes #2415

How should this be tested?

  • Check the response sharing page of any survey, response tags should be visible

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:26pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 4:26pm

@github-actions github-actions bot added the enhancement New feature or request label Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 15, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

mattinannt
mattinannt approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 looks good, thank you :-)

@mattinannt mattinannt added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit e475179 Apr 18, 2024
12 checks passed
@mattinannt mattinannt deleted the 2415-feature-let-viewer-role-see-tags branch April 18, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Let viewer-role see tags
2 participants
@gupta-piyush19 @mattinannt