fix: secure send embed preview email action & show env id in email body #2475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
requested changes
Apr 18, 2024
| }; | ||
|
|
||
| export const sendEmailAction = async ({ html, subject, to }: TSendEmailActionArgs) => { | ||
| export const sendEmbedSurveyPreviewEmailAction = async ({ surveyId }: { surveyId: string }) => { |
There was a problem hiding this comment.
can we also pass the arguments directly without an object. This is how we do it in most actions and since an action is a function and not a component I think this makes sense :-)
.../web/app/(app)/environments/[environmentId]/surveys/[surveyId]/(analysis)/summary/actions.ts
Show resolved
Hide resolved
mattinannt
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated