chore: handle people and attributes separately to improve sync performance #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
commented
Apr 25, 2024
There was a problem hiding this comment.
@pandeymangg Looks great! :-)
A few suggestion I found while going through the code. Since we are now moving towards Formbricks 2.0 I think it's good if we clean up some things if we notice them :-)
.../app/(app)/environments/[environmentId]/(peopleAndSegments)/people/components/PersonCard.tsx
Outdated
Show resolved
Hide resolved
.../app/(app)/environments/[environmentId]/(peopleAndSegments)/people/components/PersonCard.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/api/v1/client/[environmentId]/app/sync/[userId]/route.ts
Outdated
Show resolved
Hide resolved
…rmbricks into feature/split-person-model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft: not fully implemented, @pandeymangg will take over
What does this PR do?
handle people and attributes separately to improve sync performance
Since we are not always needing the whole person model with all attributes (e.g. for checks if a person exists) it doesn't make sense to query the whole model where we also might not have a cache hit if the attributes were updated.