Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handles errors while loading surveys pkg #2489

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Fixes this sentry issue where the surveys package would error out while loading and that lead to an error being thrown because the renderSurveyInline method was getting called on an undefined object.

How should this be tested?

  • fail the loading of the surveys package
  • no error should be thrown on the client

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Apr 19, 2024 6:48am
formbricks-com ⬜️ Ignored (Inspect) Apr 19, 2024 6:48am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg thank you for the fix; looks good :-) 🚀

@mattinannt mattinannt added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 06f2d85 Apr 19, 2024
14 checks passed
@mattinannt mattinannt deleted the hotfix/load-survey-script branch April 19, 2024 07:20
Copy link

sentry-io bot commented Apr 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted ... N(<anonymous>) View Issue
  • ‼️ NotFoundError: The object can not be found here. N(s/clv3z508k00x9abj813qgnvmn) View Issue
  • ‼️ TypeError: Failed to fetch fetch(chunks/app/types/errorHandlers) View Issue
  • ‼️ NotFoundError: Failed to execute 'insertBefore' on 'Node': The node before which the new node is to be inserted ... E(<anonymous>) View Issue
  • ‼️ NotFoundError: The object can not be found here. E(environments/clvph885l006w6xaqn314torm/survey... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants