Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes form submission #2492

Merged
merged 2 commits into from
Apr 19, 2024
Merged

fix: fixes form submission #2492

merged 2 commits into from
Apr 19, 2024

Conversation

pandeymangg
Copy link
Contributor

@pandeymangg pandeymangg commented Apr 19, 2024

What does this PR do?

Fixes this sentry issue where the formRef.current.requestSubmit function is not working as it is not supported by safari. This change introduces two buttons, one for just the continue which updates the state and another for submitting the form.

How should this be tested?

  • Go to the signup form and choose continue with email
  • It should work on safari!

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 9:34am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 9:34am

Copy link
Contributor

github-actions bot commented Apr 19, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@mattinannt mattinannt added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit 82853c8 Apr 19, 2024
13 checks passed
@mattinannt mattinannt deleted the hotfix/submit branch April 19, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants