Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds try...catch in all services #2494

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

  • adds try...catch in all services
  • code consistency(fixed unstable_cache keys)

Fixes https://formbricks.sentry.io/issues/5062692870

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 7:07am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 7:07am

Copy link
Contributor

github-actions bot commented Apr 19, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@gupta-piyush19 gupta-piyush19 self-assigned this Apr 19, 2024
@mattinannt
Copy link
Member

@gupta-piyush19 It seems we have some issues with e2e tests. Can you please check on this? :-)

@mattinannt mattinannt added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit 4ee27f9 Apr 22, 2024
12 checks passed
@mattinannt mattinannt deleted the fix/refactoring-and-consistency branch April 22, 2024 07:26
Copy link

sentry-io bot commented Apr 22, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ **DatabaseError: ** <anonymous>(server/chunks/packages/lib/response... View Issue
  • ‼️ **DatabaseError: ** <anonymous>(server/chunks/packages/lib/response... View Issue
  • ‼️ **DatabaseError: ** revalidate(server/chunks/packages/lib/environme... View Issue
  • ‼️ Error: Unable to get first environment: Product clvgyo7ym0003d9n0iqu0icvd has no production environment getFirstEnvironmentByUserId(server/chunks/packa... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants