Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix S3 credential checks #2513

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

jonas-hoebenreich
Copy link
Contributor

What does this PR do?

Fixes #2512

How should this be tested?

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 23, 2024

@jonas-hoebenreich is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the bug Something isn't working label Apr 23, 2024
Copy link
Contributor

github-actions bot commented Apr 23, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@mattinannt
Copy link
Member

connected to #2144

@pandeymangg Can you please take a look? :-)

Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @jonas-hoebenreich 😊 I just removed the unused environment variables related to AWS sdk, lets merge this 🚀

@pandeymangg pandeymangg added this pull request to the merge queue Apr 26, 2024
Merged via the queue into formbricks:main with commit 4c351f8 Apr 26, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] AWS S3 Credential Chain
3 participants