Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds loader in the thankyou card while response submission #2520

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

adds loader in the thankyou card while response submission

Fixes
https://github.com/formbricks/internal/issues/111
image

How should this be tested?

  • Fill a survey quickly and see the thankyou card will display only after the successful response submission

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 1:50pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 1:50pm

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the logic cause it showed media even though it was loading and was a bit tangled

@mattinannt mattinannt added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit a9bf8fc Apr 24, 2024
10 of 12 checks passed
@mattinannt mattinannt deleted the 111-bug-show-thank-you-card-on-successful-submission branch April 24, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants