Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recontact options for in-app surveys #2525

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Adds Documentation for Recontact Options for App Surveys

Fixes https://github.com/formbricks/internal/issues/118

How should this be tested?

image
image
image
image
image

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 5:06pm
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 26, 2024 5:06pm

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The first 30% of this screenshot are irrelevant and potentially misleading. Let's keep the screenshots to the UI which is important 🤓

Other than that, very good! Edited the beginning a bit for clarity.

@jobenjada jobenjada merged commit d41d60d into main Apr 26, 2024
9 of 11 checks passed
@jobenjada jobenjada deleted the shubham/docs-recontact branch April 26, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants