Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Slick card look #2531

Merged
merged 46 commits into from
May 7, 2024
Merged

feat: Slick card look #2531

merged 46 commits into from
May 7, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes https://github.com/formbricks/internal/issues/74

Screen-Recording-2024-04-25-at-4.05.23.PM.mp4
Screen-Recording-2024-04-25-at-4.05.00.PM.mp4

How should this be tested?

Go to card settings
Choose among the available card arrangements

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:53pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-com ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 1:53pm
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 1:53pm

Copy link
Contributor

github-actions bot commented Apr 25, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@Dhruwang Dhruwang changed the title Slick card look feat: Slick card look Apr 25, 2024
@Dhruwang Dhruwang requested a review from jobenjada April 25, 2024 11:25
@Dhruwang Dhruwang self-assigned this Apr 25, 2024
Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dhruwang

thanks for this, looks really slick already :) We'll have to do a bit of tweaking to get to the look & feel that we want for the cards and overall UX:

Settings UX

  1. Only display relevant settings:
image

We know here what survey type this survey is so pls only display the relevant setting.


  1. Backwards compatibility: My existing survey was rendered with "casual".
image

I think we should set all existing surveys to straight or simple (I prefer straight to get the look out there :) )


Highlight border clashes:

image

(looks like a 🦓 )


Date Picker and Cal Embed not working
image

image

Cards Look and Feel

  1. The cards don't get smaller the further they are away:
image

Now that I looked for where I designed that I couldn't even find it 🙈 Pls scale them down a bit and the further they are away the smaller they get.

This also means that the cards need to get scaled up when they go from the stack to become the main question card. This will give the whole look more depth 🤓


  1. Corner border weak: The border is inconsistent. Please make sure it doesnt fade out on the corners:
image
  1. Animation issue: You can see the content of the Thank You card while the second card fades in with opacity.
fade-issue.mp4

  1. It seems like there is an additional empty card somewhere. You can see it best when the Thank You card fades in
additional-card.mp4

  1. The hover effect is a bit too slow / delayed. Please have a look at what I built for the Verify Email screen and use this animation: The scale up is snappy / immediately and the cards in the back are slightly delayed and slower.

  1. The progress bar looks broken. We should hide it on the cards which are staked behind:
image
  1. The animate out and in is too "much"
animate.out.mp4

Status quo: The card slides to the left end of the screen and is visible the whole time
What we need: The card slides a bit (~15% screen width) to the right and then fades out

Big elements flying long distances never looks good. We want to have a subtle movement.


  1. OPTIONAL (do last): Change the direction of "Animate out" for straight card style:

Currently, the card always moves to the right.

For the card "Straight" I'd love the cards to move down and fade out. Since the card stack are clearly positioned above the main visible question card, it will feel more intuitive that the card fades down and out and the next card comes from above.


  1. Assure that easing is added to all animations: https://tailwindcss.com/docs/transition-timing-function#controlling-the-easing-curve

  1. Card height issue:
height-change.mp4

Status: As soon as we click "Next" the height of the current card snaps to the height of the following card.
Solution: This shouldn't happen (or it should be slower and animated). It doesn't feel natural that the height of the card changes because the content of it doesn't change (from a logical point of view, not from a technical point of view).

@Dhruwang Dhruwang requested a review from mattinannt May 3, 2024 10:04
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang smaller things I saw while scrolling through the code. Please fix before the merge :-)

@jobenjada
Copy link
Member

hey @Dhruwang

here are some more things I noticed:

  1. The next button pops up in the out animation. Pls resolve:
slick-next-btn.mp4

  1. Is this an optical illusion or do the cards move down and to the right? It's really hard to tell :D Not horrible but if you have an idea why its not moving straight down, pls check ;)
slick-down-right.mp4

  1. if you go from a long card to a shorter one you can see the Thank You tick flickr up briefly:
slick-thank-you-flicker.mp4

Any non-hacky idea to solve this?


  1. UX Remark: Is there a non-hacky way to reset the survey back to start on switching the card arrangement? If your at the end of the survey (or only have 1 cards left) the difference isn't really apparent:
image
  1. In app: The Close icon is acting weird. It's missing on most cards and sometimes coming through:
slick-close-icon.mp4

  1. In app: Height change smoothness

The height change is much smoother for links surveys compared to in-app. Any idea why? 🤔

Uploading slick-smoothness.mp4…


  1. If we choose "Simple" on In-app surveys we see a flicker between different cards:
    https://github.com/formbricks/formbricks/assets/72809645/399a7fda-9eba-473e-b688-9e10664fbf52

Don't see it for link surveys. Pls look into it.


I think that's it ;)

@mattinannt mattinannt enabled auto-merge May 7, 2024 12:31
@mattinannt mattinannt added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 3a1683e May 7, 2024
10 of 12 checks passed
@mattinannt mattinannt deleted the slick-card-look branch May 7, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants