Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button label issue #2549

Merged
merged 3 commits into from
May 2, 2024
Merged

fix: Button label issue #2549

merged 3 commits into from
May 2, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes https://github.com/formbricks/internal/issues/117

By default we dont have keys for buttonLabel and backButtonLabel, when a user attempts to modify the buttonLabel in a question, a key for it is automatically generated if it doesn't already exist. However, if this key is subsequently set to an empty value, it triggers a validation error. To address this issue, we now remove the key if it is left empty.

How should this be tested?

  1. Change next button label or back button label for a question
  2. Set it empty
  3. Try to save the survey

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview May 2, 2024 10:14am
formbricks-com ⬜️ Ignored (Inspect) May 2, 2024 10:14am

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor

@pandeymangg pandeymangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@pandeymangg pandeymangg enabled auto-merge May 2, 2024 10:17
@pandeymangg pandeymangg added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit e707713 May 2, 2024
11 checks passed
@pandeymangg pandeymangg deleted the button-label-issue branch May 2, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants