Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Matrix Validation UX #2551

Merged
merged 1 commit into from
Apr 29, 2024
Merged

fix: Matrix Validation UX #2551

merged 1 commit into from
Apr 29, 2024

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Fixes https://github.com/formbricks/internal/issues/106
We show a toast onBlur when there are identical rows/columns like we do in multi select questions
Also it makes the card red, if some validation error exist

How should this be tested?

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 7:41am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Apr 29, 2024 7:41am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada
Copy link
Member

UX looks good, @mattinannt pls do / assign code review

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX looks good (see comment on Slack)

@jobenjada jobenjada added this pull request to the merge queue Apr 29, 2024
Merged via the queue into main with commit 8b54436 Apr 29, 2024
14 checks passed
@jobenjada jobenjada deleted the matrix-question-validation-ux branch April 29, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants