Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email embed styles #2554

Merged
merged 6 commits into from
May 2, 2024
Merged

fix: email embed styles #2554

merged 6 commits into from
May 2, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Fixes the email embed not being styled the same as the survey bug. Takes the styling preferences from the survey / product styling object and applies to all the email templates.

Fixes 123(issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) Visit Preview Apr 30, 2024 4:19pm
formbricks-com 猬滐笍 Ignored (Inspect) Visit Preview Apr 30, 2024 4:19pm

Copy link
Contributor

github-actions bot commented Apr 29, 2024

Thank you for following the naming conventions for pull request titles! 馃檹

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg Thank you for the PR :-)
Colors look great
Screenshot 2024-04-29 at 16 48 23

But I would also like to see the roundness. This is what my survey looks like in a Link survey:
Screenshot 2024-04-29 at 16 49 39

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg thanks for the changes; looks great! :-)

@mattinannt mattinannt added this pull request to the merge queue Apr 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 30, 2024
@mattinannt mattinannt added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit fc15017 May 2, 2024
12 checks passed
@mattinannt mattinannt deleted the fix/email-styles branch May 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants