Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bundles api package with js-core #2557

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix: bundles api package with js-core #2557

merged 3 commits into from
Apr 30, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Inlines the api package type declarations in the js-core package, using the bundledPackages option in the vite-plugin-dts options.

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) Visit Preview Apr 30, 2024 10:35am
formbricks-com 猬滐笍 Ignored (Inspect) Visit Preview Apr 30, 2024 10:35am

Copy link
Contributor

github-actions bot commented Apr 30, 2024

Thank you for following the naming conventions for pull request titles! 馃檹

@pandeymangg pandeymangg mentioned this pull request Apr 30, 2024
11 tasks
@pandeymangg pandeymangg marked this pull request as ready for review April 30, 2024 09:49
@mattinannt mattinannt added this pull request to the merge queue Apr 30, 2024
Merged via the queue into main with commit 518d6cc Apr 30, 2024
12 checks passed
@mattinannt mattinannt deleted the fix/js-types branch April 30, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants