feat: Refactor Triggers and combine Action Classes and Inline Triggers

[gupta-piyush19]

What does this PR do?

• Refactor Triggers and combine Action Classes and Inline Triggers
• removes inline triggers completely

Fixes
https://github.com/formbricks/internal/issues/101

How should this be tested?

• run the npx prisma migrate dev to migrate the DB schema
• then run the data migration script pnpm run data-migration:refactor-actions after navigating into the packages/database directory.
• Test UI changes for any website or app survey.

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	🛑 Canceled (Inspect)			May 7, 2024 2:43pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
formbricks-com	⬜️ Ignored (Inspect)	Visit Preview		May 7, 2024 2:43pm
formbricks-docs	⬜️ Ignored (Inspect)	Visit Preview		May 7, 2024 2:43pm

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[mattinannt]

@gupta-piyush19 thanks a lot for the feature! :-) 💪
I already had a very brief look at the code and added some comments :-)

[jobenjada]

Hey Piyush!

I came across a few more issues:

1. There is an issue with the selection of the actions:

actions-search.mp4

After seraching, it shows a wider range of options to choose from.

---

2. Saving Error + it does not prevent Survey Editor closing:

actions-saving-bug.mp4

I'm getting the Save Error with preexisting surveys, not with new ones. Maybe the migration did not work as planned?

Looks like it is because I created the surveys with the Slick Card PR.

But pls still look into why the Save & Close closes the editor even though we throw an error.

---

3. Remove duplicate forms: Use the Action Create form from the Survey Editor on the Actions page:

replace:

with:

Thanks a lot! :)

[gupta-piyush19]

Hey Piyush!

I came across a few more issues:

1. There is an issue with the selection of the actions:

actions-search.mp4
After seraching, it shows a wider range of options to choose from.

2. Saving Error + it does not prevent Survey Editor closing:

actions-saving-bug.mp4
I'm getting the Save Error with preexisting surveys, not with new ones. Maybe the migration did not work as planned?

Looks like it is because I created the surveys with the Slick Card PR.

But pls still look into why the Save & Close closes the editor even though we throw an error.

3. Remove duplicate forms: Use the Action Create form from the Survey Editor on the Actions page:

replace:

with:

Thanks a lot! :)

Thanks, @jobenjada, for the review. 🙌

1. fixed the search actions bug. 🔍
2. It seems like your DB schema is not migrated correctly. Both slick card changes and the actions PR migrations are implemented on your DB. Can you please try calibrating the DB schema from the main branch and then check out the actions PR?
3. Done ✅