Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: types resolution #2563

Merged
merged 4 commits into from
May 6, 2024
Merged

fix: types resolution #2563

merged 4 commits into from
May 6, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Note: This is a WIP
Introduces ways to get the types for @formbricks/js working correctly, right now the js package is types as any, with this there are atleast the method types on formbricks object. Its still not completed, needs more research

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 4:50am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formbricks-com ⬜️ Ignored (Inspect) May 6, 2024 4:50am

Copy link
Contributor

github-actions bot commented May 1, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@pandeymangg pandeymangg changed the title fix: begin fixing the types resolution fix: types resolution May 1, 2024
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg Looks great!! 😊💪

@mattinannt mattinannt added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit bc28936 May 6, 2024
11 checks passed
@mattinannt mattinannt deleted the fix/formbricks-types branch May 6, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants