Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use localized question headline when extracting survey details #2569

Merged
merged 2 commits into from
May 3, 2024

Conversation

gcascio
Copy link
Contributor

@gcascio gcascio commented May 2, 2024

What does this PR do?

Currently the question headers in exported response files (CSV and Excel) are displayed as [object Object]. The reason is that the headlines of questions are used directly in a string template although they are records.

How should this be tested?

  • Add at least one question to a survey and then export the responses as CSV or Excel

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 2, 2024

@gcascio is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented May 2, 2024

Thank you for following the naming conventions for pull request titles! 馃檹

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gcascio thanks a lot for this fix! 馃殌馃挭 Looks great! :-)

@mattinannt mattinannt enabled auto-merge May 3, 2024 15:16
@mattinannt mattinannt added this pull request to the merge queue May 3, 2024
Merged via the queue into formbricks:main with commit a9a09f3 May 3, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants