-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modified google sheet integration and minor refactors in other integrations #2572
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang sorry for the late review :-) Code looks great :-) There are only two small questions I added below.
Also can you please check the docs page ( https://formbricks.com/docs/self-hosting/integrations#google-sheets ) if changes needs to be made here? :-)
...p)/environments/[environmentId]/integrations/google-sheets/components/GoogleSheetWrapper.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang thanks for making the changes :-) :-) Let's merge this!
What does this PR do?
Screen-Recording-2024-05-03-at-3.04.04.PM.mp4
Fixes https://github.com/formbricks/internal/issues/132
How should this be tested?
Test google sheet integraton
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated