Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes survey createdBy filtering for null createdBy surveys #2577

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

  • fixes survey createdBy filtering for null createdBy surveys

Fixes
https://github.com/formbricks/internal/issues/124

How should this be tested?

  • Add a new member to the team
  • Create a survey using the invited user's account in the invited team.
  • Remove the invited user from the team
  • Delete the invited user's account
  • Now the survey would have null in the createdBy.
  • Do the survey filtering, and this survey should be visible under the createdBy:Others filter

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 0:06am

Copy link
Contributor

github-actions bot commented May 6, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you :-)

@mattinannt mattinannt enabled auto-merge May 6, 2024 11:51
@mattinannt mattinannt added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 386436a May 6, 2024
13 checks passed
@mattinannt mattinannt deleted the 124-bug-survey-filters-not-showing-all-surveys-in-development-environment branch May 6, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants