Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revamp docker compose with new env vars & formatting #2583

Merged
merged 3 commits into from
May 7, 2024

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Adds missing environment variables to the docker compose that's exposed in Single Click as well as Advanced Self Hosting Setup with cleaner formatting.

Fixes https://github.com/formbricks/internal/issues/138

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 1:33pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 1:33pm

Copy link
Contributor

github-actions bot commented May 7, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala thank you; looks great :-) Makes the docker compose much more readable :-) I only updated some smaller things (e.g. moving EE up, so people think more about getting a license ;-) )

@mattinannt mattinannt enabled auto-merge May 7, 2024 12:30
@mattinannt mattinannt added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit 2ca38b1 May 7, 2024
10 of 12 checks passed
@mattinannt mattinannt deleted the shubham/add-new-envs-to-client-docker-compose branch May 7, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants