Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds search filter for value selection in logic editor #2584

Merged
merged 4 commits into from
May 10, 2024
Merged

fix: adds search filter for value selection in logic editor #2584

merged 4 commits into from
May 10, 2024

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

Adds search filter for value selection in logic editor

Fixes
#2578

bugfix.mp4

How should this be tested?

  • Create a select question with lots of options
  • Add a logic jump

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 4:30pm
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 4:30pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 7, 2024 •
edited

Thank you for following the naming conventions for pull request titles! 🙏

@gupta-piyush19 gupta-piyush19 changed the title fixes: adds search filter for value selection in logic editor fix: adds search filter for value selection in logic editor May 7, 2024
jobenjada
jobenjada approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made a few tiny tweaks, looked great already :)

@jobenjada jobenjada added this pull request to the merge queue May 10, 2024
Merged via the queue into main with commit 49bf9ec May 10, 2024
12 checks passed
@jobenjada jobenjada deleted the 2578-bug-lots-of-answer-options-break-logic-jump-selector branch May 10, 2024 13:21
@jobenjada jobenjada mentioned this pull request May 10, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jobenjada jobenjada jobenjada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gupta-piyush19 @jobenjada