Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds Thank You card loading #2585

Merged
merged 2 commits into from
May 7, 2024
Merged

fix: Adds Thank You card loading #2585

merged 2 commits into from
May 7, 2024

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

Adds welcome card loading

Fixes # (issue)
image

How should this be tested?

  • Fill out a survey quickly and see the thankyou card will display only after the successful response submission

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud 🛑 Canceled (Inspect) May 7, 2024 2:43pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 2:43pm

Copy link
Contributor

github-actions bot commented May 7, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada jobenjada changed the title fix: Adds welcome card loading fix: Adds Thank You card loading May 7, 2024
Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick turnaround :)

@jobenjada jobenjada added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit f529f5e May 7, 2024
10 of 12 checks passed
@jobenjada jobenjada deleted the bug-welcome-card-loading branch May 7, 2024 13:27
@vercel vercel bot temporarily deployed to Preview – formbricks-cloud May 7, 2024 14:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants