-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve Preview Full Screen Modal Animation #2588
feat: Improve Preview Full Screen Modal Animation #2588
Conversation
@yatharth1706 is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
hey mate! Love to see you come back and get the job done 💪 :D we'll look into it when the 2.0 is out! :) |
Sure @jobenjada no worries. I was just learning more about animations and was tinkering with framer motion a lot in past few days. And i thought lets just give it a try again to improve the preview full screen animation. And hence i submitted a PR again. |
Hey! @yatharth1706 Thanks for opening the PR 😊 , could you please look into this? The preview survey is not visible in the full screen preview. Screen.Recording.2024-05-15.at.9.32.27.AM.mov |
Yeah Sure, I will take a look at that in some time. Thanks |
Keeping this in draft version for now. Some strange behaviour happening with the modals inside preview screen when its maximized. Those are getting invisible. I will check that in some time. |
@pandeymangg i was checking the code. Inside preview modal, survey modal is getting dynamically added in the runtime. I believe that is causing some strange behaviour. Because for adding the animation i am using shared layouts of framer motion and in that i have to create the preview modal twice. One is the existing and second is the one which covers the whole screen when maximized. So because of having two components and as our survey modal is dynamically added at the runtime, i believe that is causing some strange issues. Do you have any idea on how we can fix that and show the survey modal in the maximized component as well ? |
What does this PR do?
Made the animation look more natural when expanding the preview modal or shrinking it
Fixes # (issue)
Screen.Recording.2024-05-07.at.6.14.29.PM.mov
How should this be tested?
Checklist
Required
pnpm build
console.logs
git pull origin main
Appreciated