Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added timeout before response submission for rating and NPS question #2594

Merged
merged 3 commits into from
May 9, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented May 8, 2024

What does this PR do?

Fixes #2523

Before

Screen-Recording-2024-05-08-at-3.56.56.PM.mp4

After

Screen-Recording-2024-05-08-at-3.57.13.PM.mp4

Right now timeout value is set to 250ms

How should this be tested?

Test NPS/ rating question

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) Visit Preview May 9, 2024 2:46pm
formbricks-docs 猬滐笍 Ignored (Inspect) Visit Preview May 9, 2024 2:46pm

Copy link
Contributor

github-actions bot commented May 8, 2024

Thank you for following the naming conventions for pull request titles! 馃檹

@jobenjada jobenjada self-requested a review May 9, 2024 15:42
Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@jobenjada jobenjada added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit 555f5c3 May 9, 2024
12 checks passed
@jobenjada jobenjada deleted the nps-rating-tweak branch May 9, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Selection Indicator missing (FF on Android)
2 participants