Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect format note in multiple best practices page #2595

Merged
merged 1 commit into from
May 9, 2024

Conversation

frank-mendez
Copy link
Contributor

What does this PR do?

Fixes #2592

Screenshot from 2024-05-09 01-20-41
2.
Screenshot from 2024-05-09 01-20-32
3.
Screenshot from 2024-05-09 01-20-20

How should this be tested?

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 8, 2024

@frank-mendez is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added bug Something isn't working Docs good first issue Good for newcomers 🕹️ 100 points 🕹️ oss.gg Community issue via oss.gg labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada jobenjada self-requested a review May 9, 2024 14:43
Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot mate :)

@jobenjada jobenjada enabled auto-merge May 9, 2024 14:43
@jobenjada
Copy link
Member

/award 100

Copy link

oss-gg bot commented May 9, 2024

Awarding frank-mendez: 100 points!

@jobenjada jobenjada added this pull request to the merge queue May 9, 2024
Merged via the queue into formbricks:main with commit 556ee87 May 9, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Docs good first issue Good for newcomers 🕹️ oss.gg Community issue via oss.gg 🕹️ 100 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Docs: Incorrectly formatted Note in multiple Best Practises pages
2 participants