Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modal z-index #2626

Merged
merged 1 commit into from
May 15, 2024
Merged

fix: modal z-index #2626

merged 1 commit into from
May 15, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Fixes the z-index issue with the new modal component leading to issues like the delete response modal being below the response card.

Fixes # (issue)

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) May 15, 2024 8:12am
formbricks-docs 猬滐笍 Ignored (Inspect) May 15, 2024 8:12am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 馃檹

@mattinannt mattinannt added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit b5287f7 May 15, 2024
14 checks passed
@mattinannt mattinannt deleted the hotfix/z-index branch May 15, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants