Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handles error in json input parsing in the management endpoints #2634

Merged
merged 1 commit into from
May 16, 2024

Conversation

pandeymangg
Copy link
Contributor

What does this PR do?

Fixes formbricks/internal#185/
Adds a try catch block around all the json input parsing in the PUT and POST endpoints in the management api

How should this be tested?

  • Send some malformed json input in any management PUT or POST endpoint
  • The api should return a 400 bad request error and not a 500 internal server error

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 馃檹

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud 猬滐笍 Ignored (Inspect) May 16, 2024 7:07am
formbricks-docs 猬滐笍 Ignored (Inspect) May 16, 2024 7:07am

Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 馃檹

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandeymangg thank you for the fix; looks good! 馃槉馃挭

@mattinannt mattinannt added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 9849a96 May 16, 2024
14 checks passed
@mattinannt mattinannt deleted the fix/management-json-input branch May 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants