fix: survey overview is throwing a server-side error #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
reviewed
May 16, 2024
There was a problem hiding this comment.
@gupta-piyush19 thanks for the PR :-) quick question/suggestion:
| @@ -90,6 +90,14 @@ export const MainNavigation = ({ | |||
| localStorage.setItem("isMainNavCollapsed", isCollapsed ? "false" : "true"); | |||
| }; | |||
|
|
|||
| useEffect(() => { | |||
| if (typeof window !== "undefined") { | |||
There was a problem hiding this comment.
Since a useEffect is always running in client / browser, do we need this check here or can we also simplify this by removing the window check?
There was a problem hiding this comment.
yeah, makes sense 👍
…183-survey-overview-is-throwing-a-server-side-error
mattinannt
approved these changes
May 17, 2024
There was a problem hiding this comment.
@gupta-piyush19 thanks for making the changes; looks great! :-)
mattinannt
deleted the
183-survey-overview-is-throwing-a-server-side-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
mainNavigation.tsxFixes
https://github.com/formbricks/internal/issues/183
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated