Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input color issue on rating questio #2641

Merged
merged 2 commits into from
May 17, 2024
Merged

fix: input color issue on rating questio #2641

merged 2 commits into from
May 17, 2024

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented May 16, 2024

What does this PR do?

Fixes #2627

How should this be tested?

Screenshot 2024-05-16 at 6 05 28 PM

Increased close button size

Before

Screenshot 2024-05-17 at 10 30 07 AM

After

Screenshot 2024-05-17 at 10 36 05 AM

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 5:07am
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 5:07am

@github-actions github-actions bot added the bug Something isn't working label May 16, 2024
Copy link
Contributor

github-actions bot commented May 16, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks for the change :-) 💪

The issue you referenced also includes the following request:

  1. The interactive area of the close icon is just 16x16px. This makes is hard to close the survey on mobile devices and does not comply with WCAG standards. see fix: improve a11y of survey modal close button #1661

Can you please also fix this issue in this PR? :-)

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks for the changes; looks great! :-)

@mattinannt mattinannt added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 084307b May 17, 2024
13 checks passed
@mattinannt mattinannt deleted the a11y-issues branch May 17, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] a11y issues
2 participants