Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: File Upload currently only supports 10 files #2642

Merged
merged 4 commits into from
May 23, 2024

Conversation

gupta-piyush19
Copy link
Contributor

What does this PR do?

  • fixes max upload limit of file upload question
  • File Upload currently only supports 10 files

Fixes
https://github.com/formbricks/internal/issues/187

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 10:50am
formbricks-docs ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 10:50am

Copy link
Contributor

github-actions bot commented May 17, 2024

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gupta-piyush19 works great; thanks for cleaning the file up while increasing the limit 😊🚀🧹🧼

@mattinannt mattinannt added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 4544cba May 23, 2024
12 checks passed
@mattinannt mattinannt deleted the 187-file-upload-currently-only-supports-10-files branch May 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants