feat: change question type #2646
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
There was a problem hiding this comment.
@pandeymangg works great :-) I only have one concern regarding the survey constants:
There was a problem hiding this comment.
We already have this file apps/web/app/lib/questions.ts:
formbricks/apps/web/app/lib/questions.ts
Line 60 in 0d36e11
Can we reuse this and/or combine this into one file to have a single source of truth for question types?
apps/web/app/lib/questions.tsx
Outdated
| @@ -230,3 +231,35 @@ export const getTSurveyQuestionTypeName = (id: string) => { | |||
| const questionType = questionTypes.find((questionType) => questionType.id === id); | |||
| return questionType?.label; | |||
| }; | |||
|
|
|||
| export const QUESTIONS_ICON_MAP: Record<TSurveyQuestionType, JSX.Element> = { | |||
There was a problem hiding this comment.
Can we somehow avoid to declare things twice? We already listed out all the question types toegther with their icons in the questionTypes variable. could we reuse this instead of defining again what question types exists and what their icon and name is?
There was a problem hiding this comment.
@pandeymangg thanks for making the changes, looks great! :-)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
What does this PR do?
Implements the change question type feature
Fixes #2579
Screen.Recording.2024-05-17.at.6.42.32.PM.mov
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated