fix: adds react hook form to product general settings #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 馃檹 |
pandeymangg
changed the title
mattinannt
reviewed
May 23, 2024
There was a problem hiding this comment.
@pandeymangg Nice, it's coming together 馃殌 A quick review and question :-) I also need to dig a little deeper into the react hook form to see how we can tweak it.
I think since this is kind of a reference design for how we do forms in Formbricks, it should be as good and well thought out as possible 馃槉
| isProductNameEditDisabled: boolean; | ||
| }; | ||
|
|
||
| const editProductNameSchema = ZProduct.pick({ name: true }); |
There was a problem hiding this comment.
I think it would be more consistent if we name this e.g. ZProductNameInput or similar that we know that this is a zod type.
...eb/app/(app)/environments/[environmentId]/product/general/components/EditProductNameForm.tsx
Outdated
Show resolved
Hide resolved
mattinannt
approved these changes
May 24, 2024
mmopinodo
pushed a commit
to Opinodo/opinodo-surveys
that referenced
this pull request
Jun 12, 2024
(cherry picked from commit 6d6a47a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds react hook form support for the product look and feel setting's placement form, and refactors the product general settings to use the zod resolver with react hook form
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated