Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Rendering (previously Client): ActionClass & AttributeClass Overviews #495

Merged
merged 21 commits into from
Jul 18, 2023
Merged

Server Rendering (previously Client): ActionClass & AttributeClass Overviews #495

merged 21 commits into from
Jul 18, 2023

Conversation

ShubhamPalriwala
Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala commented Jul 7, 2023 •
edited

What does this PR do?

  • Migrates the /event to /action across the repo and some of the named variables as well (most are still left which can be done later as well ie once you review the important changes)
  • Migrates the events (now actions) overview page to serverside
  • Migrates the attributes overview page to serverside
  • Implements skeleton loaders for both actions and attributes tables
  • The actions and attributes are now just components that are logicall differentiated as per the parenthesis directory naming
  • /environments/[environmentId]/[actionsAndAttributesOption] is now a param based on which we either load the actions page or the attributes page

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update (Might need since routes have changed @mattinannt lmk what you think on this)

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Jul 7, 2023

@ShubhamPalriwala is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

mattinannt
mattinannt reviewed Jul 7, 2023
View reviewed changes
packages/lib/services/action.ts Outdated Show resolved Hide resolved
packages/lib/services/action.ts Outdated Show resolved Hide resolved
packages/lib/services/action.ts Outdated Show resolved Hide resolved
packages/lib/services/serverActions.ts Outdated Show resolved Hide resolved
@ShubhamPalriwala ShubhamPalriwala marked this pull request as ready for review July 10, 2023 12:42
@ShubhamPalriwala ShubhamPalriwala changed the title Server Rendering (previously Client): ActionClass Server Rendering (previously Client): ActionClass & AttributeClass Overviews Jul 10, 2023
mattinannt
mattinannt reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShubhamPalriwala 💪 Looks great so far. I left a few comments 😊

apps/web/app/environments/[environmentId]/[actionsAndAttributesOption]/layout.tsx Outdated Show resolved Hide resolved
apps/web/app/environments/[environmentId]/[actionsAndAttributesOption]/page.tsx Outdated Show resolved Hide resolved
...p/environments/[environmentId]/[actionsAndAttributesOption]/(attributes)/AttributeLoader.tsx Outdated Show resolved Hide resolved
apps/web/components/actions_attributes/ActionsAttributesTabs.tsx Outdated Show resolved Hide resolved
packages/lib/services/action.ts Outdated Show resolved Hide resolved
packages/lib/services/action.ts Outdated Show resolved Hide resolved
packages/lib/services/action.ts Outdated Show resolved Hide resolved
@jobenjada
Copy link
Member

@ShubhamPalriwala pls follow up :)

mattinannt
mattinannt reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes 🤗 I fixed some small issues but also left a few comments. Would be great if you can update these last things 🤗

apps/web/app/environments/[environmentId]/(actionsAndAttributes)/actions/ActionSettingsTab.tsx Outdated Show resolved Hide resolved
apps/web/app/environments/[environmentId]/(actionsAndAttributes)/actions/ActionSettingsTab.tsx Outdated Show resolved Hide resolved
...web/app/environments/[environmentId]/(actionsAndAttributes)/actions/AddNoCodeActionModal.tsx Outdated Show resolved Hide resolved
mattinannt
mattinannt approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🎉🤗

@mattinannt mattinannt merged commit 3824d95 into formbricks:main Jul 18, 2023
0 of 2 checks passed
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
@ShubhamPalriwala @mattinannt
Move Actions & Attributes pages over to server components (formbricks…
069290e 
…#495)

* feat: server rendering of event actions summary page & server actions

* chore: renaming event to action and minor refactoring

* fix: logging message

* delete: unnecessary file

* feat: migrate attributes overview page

* feat: impl grouped page & layout, logically differentiate attributes and actions

* pnpm format

* fix: logical addressing of dirs and minot bugs

* move: actionsAndAttributes navbar to dedicated dir from components

* fix: use server-only build-time checks and move actionsAttributes navbar

* revert: unnecessary docker compose changes

* resolve merge conflicts dynamically

* fix: address feedback comments

* use sparkles icon from heroicons

* fix updated action not updating in table

* remove async from client function due to warning

* move router.refresh in AddNoActionModal

* small rename

* feat: replace swr w server action in ActionSettingsTab

* replace custom error with ResourceNotFoundError error class

---------

Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
@ShubhamPalriwala @mattinannt
Move Actions & Attributes pages over to server components (formbricks…
3474d70 
…#495)

* feat: server rendering of event actions summary page & server actions

* chore: renaming event to action and minor refactoring

* fix: logging message

* delete: unnecessary file

* feat: migrate attributes overview page

* feat: impl grouped page & layout, logically differentiate attributes and actions

* pnpm format

* fix: logical addressing of dirs and minot bugs

* move: actionsAndAttributes navbar to dedicated dir from components

* fix: use server-only build-time checks and move actionsAttributes navbar

* revert: unnecessary docker compose changes

* resolve merge conflicts dynamically

* fix: address feedback comments

* use sparkles icon from heroicons

* fix updated action not updating in table

* remove async from client function due to warning

* move router.refresh in AddNoActionModal

* small rename

* feat: replace swr w server action in ActionSettingsTab

* replace custom error with ResourceNotFoundError error class

---------

Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
@ShubhamPalriwala @mattinannt
Move Actions & Attributes pages over to server components (formbricks…
d337640 
…#495)

* feat: server rendering of event actions summary page & server actions

* chore: renaming event to action and minor refactoring

* fix: logging message

* delete: unnecessary file

* feat: migrate attributes overview page

* feat: impl grouped page & layout, logically differentiate attributes and actions

* pnpm format

* fix: logical addressing of dirs and minot bugs

* move: actionsAndAttributes navbar to dedicated dir from components

* fix: use server-only build-time checks and move actionsAttributes navbar

* revert: unnecessary docker compose changes

* resolve merge conflicts dynamically

* fix: address feedback comments

* use sparkles icon from heroicons

* fix updated action not updating in table

* remove async from client function due to warning

* move router.refresh in AddNoActionModal

* small rename

* feat: replace swr w server action in ActionSettingsTab

* replace custom error with ResourceNotFoundError error class

---------

Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ShubhamPalriwala @jobenjada @mattinannt