Chore: Rewrite profile settings to server component #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dhruwang is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
Dhruwang
changed the title
mattinannt
requested changes
Aug 3, 2023
There was a problem hiding this comment.
@Dhruwang thanks a lot for the PR 😊 Looks pretty good already! I made a few suggestions as comments.
The most important thing is that we get the types and services right. This is still a progress as we all learn more while using this pattern all over the whole app 😊
apps/web/app/(app)/environments/[environmentId]/settings/profile/EditProfile.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/(app)/environments/[environmentId]/settings/profile/action.tsx
Outdated
Show resolved
Hide resolved
apps/web/app/(app)/environments/[environmentId]/settings/profile/action.tsx
Outdated
Show resolved
Hide resolved
…profile-setting-to-server-components
mattinannt
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
@Dhruwang thanks a lot for the PR 💪 Looks great and works as expected 🎉
I just fixed some merge conflicts and added a TProfileUpdateInput type so we don't need to rely on prisma but our own types. Now it's ready to get merged 😊
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* Chore: moved profile settings to server component * ran pnpm format * fisxed a build issue * made requested changes * made some refactors --------- Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* Chore: moved profile settings to server component * ran pnpm format * fisxed a build issue * made requested changes * made some refactors --------- Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* Chore: moved profile settings to server component * ran pnpm format * fisxed a build issue * made requested changes * made some refactors --------- Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Decoupled the components in EditProfile into individual ones (EditName, EditAvatar, DeleteAccount).
Added data fetching functions for profile to
packages/services/profile.ts(getProfile, updateProfile, deleteProfile)Added types for the same to
packages/types/v1/profile.tsAdded server actions to
action.tsxAdded a skeleton loading state
Fixes 1061
Type of change
How should this be tested?
Check profile settings
Checklist
pnpm buildconsole.logsgit pull origin main