Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature : Toggle Multi-Select and Single-Select Question Types #652

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

Dhruwang
Copy link
Contributor

@Dhruwang Dhruwang commented Aug 5, 2023

What does this PR do?

Enables single select multiple choice to be converted to multi select and vice versa

Fixes #651

Screencast-from-05-08-23-12_25_47-PM-IST.mp4

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

Create a new survey and add a multiple select question
Click on "convert to multi select" or "convert to single select" at the bottom depending on what kind of multiple select question it is.

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Aug 5, 2023

@Dhruwang is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@Dhruwang Dhruwang marked this pull request as draft August 5, 2023 08:52
@Dhruwang Dhruwang marked this pull request as ready for review August 5, 2023 09:39
@jobenjada jobenjada self-assigned this Aug 5, 2023
@jobenjada
Copy link
Member

Great job, thanks a ton for the quick turnaround! 🚀

@jobenjada jobenjada merged commit 5c9605f into formbricks:main Aug 5, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Toggle Multi-Select and Single-Select Question Types
2 participants