Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Loading State to Action Delete & Person Delete Buttons #694

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Adds loader and state management for the loaders in deletion of action and person!

Fixes

It takes 20ish seconds to delete an action on prod:

  • The modal closes immediately after button click and the action is still visible. Instead, add a loading state to the delete button and wait for the action to be deleted to close it.

Make sure the frontend does not display the action even though it was deleted.

Same is true for deleting a person

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 8:57am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2023 8:57am

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! :)

@jobenjada jobenjada merged commit de90e10 into main Aug 16, 2023
6 checks passed
@jobenjada jobenjada deleted the shubham/for-1143-add-loading-state-to-action-delete-and-person-delete-buttons branch August 16, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants