Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate URL on Redirection to avoid breaking app #748

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

When you set an invalid URL in the "Forward after survey completion" input field, the app breaks, this PR fixes it by putting a check and sending a toast when the URL is not a valid one!

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 0:54am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 0:54am

@jobenjada jobenjada merged commit 3a3f0fa into main Aug 30, 2023
6 checks passed
@jobenjada jobenjada deleted the shubham/for-1259-bug branch August 30, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants