-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds back button label adjust #753
Conversation
@Dhruwang is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
Hey @Dhruwang thanks a ton for the quick turnaround! You considered some UX things that weren't defined in the ticket - really like that!! You are thinking along form a user perspective more and more 💪💪💪 Here is my feedback: NPS Question Type & CTA Question Type Rating Question Type Other than that, works great! :) |
@jobenjada Made requested changes 😊 |
Thanks @Dhruwang - looks good :) @mattinannt - ready 2 merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dhruwang thanks a lot for this feature PR 😊💪🙏
I will merge this into main now :-)
📦 Next.js Bundle Analysis for @formbricks/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
Hi, Is there any reason that if we change back button title it is affecting all questions? Kind of trying to make all same title. |
@ykburda Good point. I will discuss this with the team. We previously made the choice because it was easy to implement and gave the back-button-label-setting the same the place in the app as the next-button-label-setting |
Matti, It is now changing all back buttons if we change at any question. It is not same as next button. I think it should be seperate |
* adds back button label adjust * update wording * made some refactors --------- Co-authored-by: Johannes <johannes@formbricks.com> Co-authored-by: Dhruwang Jariwala <dhruwang@Dhruwangs-MacBook-Pro.local> Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
* adds back button label adjust * update wording * made some refactors --------- Co-authored-by: Johannes <johannes@formbricks.com> Co-authored-by: Dhruwang Jariwala <dhruwang@Dhruwangs-MacBook-Pro.local> Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
* adds back button label adjust * update wording * made some refactors --------- Co-authored-by: Johannes <johannes@formbricks.com> Co-authored-by: Dhruwang Jariwala <dhruwang@Dhruwangs-MacBook-Pro.local> Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
What does this PR do?
Now user can set a custom label for Backbutton
Fixes 1188
Type of change
How should this be tested?
Open any question card
Click on advance settings
Edit Back button label
Checklist
pnpm build
console.logs
git pull origin main