Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds back button label adjust #753

Merged
merged 4 commits into from
Sep 6, 2023

Conversation

Dhruwang
Copy link
Contributor

What does this PR do?

Now user can set a custom label for Backbutton

Screenshot from 2023-08-31 13-42-18

Fixes 1188

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

Open any question card
Click on advance settings
Edit Back button label

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Aug 31, 2023

@Dhruwang is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@jobenjada
Copy link
Member

Hey @Dhruwang thanks a ton for the quick turnaround!

You considered some UX things that weren't defined in the ticket - really like that!! You are thinking along form a user perspective more and more 💪💪💪

Here is my feedback:

NPS Question Type & CTA Question Type
The UI is inconsistent: Label is Back instead of "Back" Button Label and the input fields are not next to each other:
image

Rating Question Type
Its not in the Advanced Settings, pls add it there
image

Other than that, works great! :)

@jobenjada jobenjada marked this pull request as draft August 31, 2023 12:19
@jobenjada jobenjada self-assigned this Aug 31, 2023
@Dhruwang Dhruwang marked this pull request as ready for review August 31, 2023 19:55
@Dhruwang
Copy link
Contributor Author

@jobenjada Made requested changes 😊

@jobenjada jobenjada assigned mattinannt and unassigned jobenjada Sep 4, 2023
@jobenjada
Copy link
Member

Thanks @Dhruwang - looks good :)

@mattinannt - ready 2 merge

Copy link
Member

@jobenjada jobenjada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Adds back button label adjust". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dhruwang thanks a lot for this feature PR 😊💪🙏
I will merge this into main now :-)

@mattinannt mattinannt merged commit 6a12168 into formbricks:main Sep 6, 2023
2 of 7 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

📦 Next.js Bundle Analysis for @formbricks/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 74.1 KB (🟢 -17 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@ykburda
Copy link

ykburda commented Sep 6, 2023

Hi, Is there any reason that if we change back button title it is affecting all questions? Kind of trying to make all same title.

@mattinannt
Copy link
Member

@ykburda Good point. I will discuss this with the team. We previously made the choice because it was easy to implement and gave the back-button-label-setting the same the place in the app as the next-button-label-setting

@ykburda
Copy link

ykburda commented Sep 12, 2023

Matti, It is now changing all back buttons if we change at any question. It is not same as next button. I think it should be seperate

waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
* adds back button label adjust

* update wording

* made some refactors

---------

Co-authored-by: Johannes <johannes@formbricks.com>
Co-authored-by: Dhruwang Jariwala <dhruwang@Dhruwangs-MacBook-Pro.local>
Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
* adds back button label adjust

* update wording

* made some refactors

---------

Co-authored-by: Johannes <johannes@formbricks.com>
Co-authored-by: Dhruwang Jariwala <dhruwang@Dhruwangs-MacBook-Pro.local>
Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
waseemrabani pushed a commit to LuminosoInsight/formbricks that referenced this pull request Feb 2, 2024
* adds back button label adjust

* update wording

* made some refactors

---------

Co-authored-by: Johannes <johannes@formbricks.com>
Co-authored-by: Dhruwang Jariwala <dhruwang@Dhruwangs-MacBook-Pro.local>
Co-authored-by: Matthias Nannt <mail@matthiasnannt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants