Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention Editing Build-time Variables in deployment Guides #756

Merged

Conversation

ShubhamPalriwala
Copy link
Contributor

What does this PR do?

We faced quite a few queries about people trying to edit the NEXT_PUBLIC_ and since they are configured at build-time, the changes are not reflected resulting in a bad UX! This PR adds a Note and a link to the From Source page to the other 2 deployment guides ie the Docker and the Single Script setup Guide.

Type of change

  • Enhancement (small improvements)
  • This change requires a documentation update

Checklist

  • Added a screen recording or screenshots to this PR
  • Filled out the "How to test" section in this PR
  • Read the contributing guide
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Aug 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formbricks-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 31, 2023 2:47pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Aug 31, 2023 2:47pm

@jobenjada jobenjada merged commit 5db3066 into main Sep 1, 2023
6 checks passed
@jobenjada jobenjada deleted the shubham/for-1253-document-how-to-change-build-time-variables branch September 1, 2023 08:11
@jobenjada
Copy link
Member

Thanks a lot Shub! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants