fix: Authorization for Profile Actions & Limit Data exposure #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
mattinannt
requested changes
Oct 2, 2023
| @@ -52,7 +50,7 @@ function DeleteAccountModal({ setOpen, open, session, profile }: DeleteAccountMo | |||
| const deleteAccount = async () => { | |||
| try { | |||
| setDeleting(true); | |||
| await profileDeleteAction(profile.id); | |||
| await profileDeleteAction(); | |||
There was a problem hiding this comment.
please rename to deleteProfileAction
| @@ -19,7 +19,7 @@ export function EditName({ profile }: { profile: TProfile }) { | |||
| className="w-full max-w-sm items-center" | |||
| onSubmit={handleSubmit(async (data) => { | |||
| try { | |||
| await profileEditAction(profile.id, data); | |||
| await profileEditAction(data); | |||
There was a problem hiding this comment.
please rename to updateProfileAction
ShubhamPalriwala
force-pushed
the
shubham/auth-for-profile
branch
from
737576a
to
9d0ad38
Compare
ShubhamPalriwala
force-pushed
the
shubham/auth-for-profile
branch
from
9d0ad38
to
636731d
Compare
mattinannt
approved these changes
Oct 2, 2023
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* feat: authzn and limit sensitive info from profile actions * fix: work on suggested changes
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* feat: authzn and limit sensitive info from profile actions * fix: work on suggested changes
waseemrabani
pushed a commit
to LuminosoInsight/formbricks
that referenced
this pull request
Feb 2, 2024
* feat: authzn and limit sensitive info from profile actions * fix: work on suggested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Edit and Delete is now done for the user by fetching from the server session rather than a client side passed parameter.
Also a couple of services did not have the response selection hence were returning passwords/other non reqd user fields. That has also been tackled in this.
Type of change
Checklist
pnpm buildconsole.logsgit pull origin main