-
Notifications
You must be signed in to change notification settings - Fork 939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: standardize error messaging in all service #920
fix: standardize error messaging in all service #920
Conversation
@rotimi-best is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions for pull request titles! 🙏 |
} | ||
|
||
throw error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotimi-best should we maybe also here throw a new UnknownError with the message of the original error? This way we only through our own errors inside the services. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep that's a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, please let me know what you think.
… standard-service-error
* fix: standardize error messaging in all service * fix: use unknownerror
* fix: standardize error messaging in all service * fix: use unknownerror
* fix: standardize error messaging in all service * fix: use unknownerror
What does this PR do?
Standardises errors thrown in all service to use our custom error class
Type of change
How should this be tested?
new Error
new Error
Checklist
pnpm build
console.logs
git pull origin main