Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added a not-connected state to the survey state indicator #975

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

prasoonmhwr
Copy link
Contributor

@prasoonmhwr prasoonmhwr commented Oct 6, 2023

What does this PR do?

  • Added a not-connected state to the survey state indicator

Fixes #972

Screenshot 2023-10-06 at 2 38 26 PM

Type of change

  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)

How to test

  • Create an in-app survey without connecting to Formbricks

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 6, 2023

@prasoonmhwr is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@jobenjada
Copy link
Member

@prasoonmhwr is this ready for review?

@jobenjada jobenjada self-assigned this Oct 6, 2023
@prasoonmhwr prasoonmhwr marked this pull request as ready for review October 6, 2023 11:00
@prasoonmhwr
Copy link
Contributor Author

@jobenjada this is ready for review

@jobenjada jobenjada merged commit c7580f0 into formbricks:main Oct 6, 2023
8 of 11 checks passed
@jobenjada
Copy link
Member

Good work, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE][FormTribe 🔥][150 Points] Add a not-connected state to the survey state indicator
2 participants