Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Pushing to Expo for master branch #19

Closed
cmwall opened this issue Feb 9, 2018 · 2 comments · Fixed by #29
Closed

Pushing to Expo for master branch #19

cmwall opened this issue Feb 9, 2018 · 2 comments · Fixed by #29
Milestone

Comments

@cmwall
Copy link

cmwall commented Feb 9, 2018

I currently have a project set up to use appr by deploying pull requests (like the docs say).

Is there a way to deploy my master branch to the master Expo branch when master is updated?

Thanks!

@jevakallio
Copy link
Contributor

This could definitely be done. All you'd really need to do is to NOT run the post-deploy script and leave out the "$CI_PULL_REQUEST" != "" or "$TRAVIS_PULL_REQUEST" != "" in the CI configuration.

Alternatively, you can run exp login and exp publish as CI steps post-build without appr, since that's what appr does internally.

@jevakallio jevakallio added this to the 2.0 milestone Mar 6, 2018
@jevakallio
Copy link
Contributor

We should investigate how we can support building non-PR branches. This would already work today, if we didn't make assumptions around having a PR to push comments to.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants