Skip to content
This repository has been archived by the owner on Apr 2, 2021. It is now read-only.

Allow any branch to be built with or without PR #29

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Allow any branch to be built with or without PR #29

merged 1 commit into from
Mar 26, 2018

Conversation

jpdriver
Copy link
Contributor

@jpdriver jpdriver commented Mar 6, 2018 •
edited
Loading

  • remove githubPullRequestId from env var validation

(if needed you can specify a specific branch with GITHUB_SOURCE_BRANCH)

closes #19

@jpdriver jpdriver requested a review from jevakallio March 6, 2018 16:57
@jpdriver jpdriver added this to the 2.0 milestone Mar 6, 2018
jevakallio
jevakallio approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@jevakallio jevakallio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jevakallio jevakallio merged commit 0446b66 into master Mar 26, 2018
@jevakallio jevakallio deleted the jp-build-without-pr branch March 26, 2018 10:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jevakallio jevakallio jevakallio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Pushing to Expo for master branch
2 participants
@jpdriver @jevakallio