FIO-5471: Remove mongoose.save from codebase #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ongoose.save-from-codebase
FIO-5471: Add $set operator for mongoDb methods
mikekotikov
force-pushed
the
FIO-5471--Removed-mongoose.save-from-codebase
branch
from
e1fc7db
to
066d101
Compare
travist
requested changes
Dec 7, 2023
| if (!item) { | ||
| return Resource.setResponse(res, {status: 404}, next); | ||
| } | ||
|
|
||
| item.set(update); | ||
| options.hooks.put.before.call( |
There was a problem hiding this comment.
Why did we remove the "options.hooks.put.before" hook?
There was a problem hiding this comment.
@travist in that case 'before' hook was just marking 'data' as modified, which is not necessary after moving from .save() to .findOneAndUpdate(). And the 'after' hook was just calling next(). Here are the screenshots of those hooks:
Before:
After:
If there's a possibility to pass custom hooks to formio that override current ones, please tell me, I'll return those calls then.
|
👍 |
lane-formio
pushed a commit
that referenced
this pull request
Apr 18, 2024
* FIO-5471: Removed mongoose.save from codebase * FIO-5471: Add small fixes * refactor submission patch * fix formatting * This is a combination of 2 commits. FIO-5471: Add $set operator for mongoDb methods --------- Co-authored-by: Travis Tidwell <travis@form.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-5471
Description
What changed?
Refactored code to not use
mongoose.save()Dependencies
formio-server:1082
How has this PR been tested?
Mostly by running tests
Checklist: